tustvold commented on code in PR #4525:
URL: https://github.com/apache/arrow-datafusion/pull/4525#discussion_r1041035609
##########
datafusion/core/src/datasource/listing/url.rs:
##########
@@ -99,10 +99,14 @@ impl ListingTableUrl {
};
let path = std::path::Path::new(prefix).canonicalize()?;
- let url = match path.is_file() {
- true => Url::from_file_path(path).unwrap(),
- false => Url::from_directory_path(path).unwrap(),
- };
+ let url = if path.is_dir() {
+ Url::from_directory_path(path)
+ } else {
+ Url::from_file_path(path)
+ }
+ .map_err(|_| DataFusionError::Internal(format!("Can not open path:
{}", s)))?;
Review Comment:
Why is this change necessary, canonicalize above will fail if the path
doesn't exist?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
