wgtmac commented on PR #14803: URL: https://github.com/apache/arrow/pull/14803#issuecomment-1339570228
> I just realized: in this API, `encoded_min_values` and `min_values` use different conventions? (one is dense, the other is sparse). After checking the potential use cases of `ColumnIndex`, I think it makes sense to follow same convention for `encoded_min_values()` and `min_values()` to have same number of pages. For predicate push down, the binary search for sorted column index can be simply done by iterating page_ids returned from `non_null_page_indices()`. The latest commit reflects this change. Please take a look, thanks! @pitrou -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
