tustvold opened a new pull request, #4529:
URL: https://github.com/apache/arrow-datafusion/pull/4529
_Draft as currently represents a non-trivial performance regression_
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Reworks SortPreservingMerge to use async instead of manual poll. This will
make it easier to iterate on as I look to integrate the row format more
comprehensively with it.
```
merge i64 time: [8.3403 ms 8.3477 ms 8.3553 ms]
change: [+9.8691% +9.9888% +10.105%] (p = 0.00 <
0.05)
Performance has regressed.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild
merge f64 time: [8.4809 ms 8.4867 ms 8.4930 ms]
change: [+8.4317% +8.5771% +8.7138%] (p = 0.00 <
0.05)
Performance has regressed.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild
merge utf8 low cardinality
time: [5.3511 ms 5.3562 ms 5.3613 ms]
change: [+7.6734% +7.8124% +7.9371%] (p = 0.00 <
0.05)
Performance has regressed.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild
merge utf8 high cardinality
time: [9.0445 ms 9.0712 ms 9.0983 ms]
change: [+6.5674% +7.0497% +7.4911%] (p = 0.00 <
0.05)
Performance has regressed.
merge utf8 tuple time: [15.445 ms 15.508 ms 15.573 ms]
change: [+1.0406% +1.7112% +2.4312%] (p = 0.00 <
0.05)
Performance has regressed.
merge utf8 dictionary time: [5.2034 ms 5.2068 ms 5.2104 ms]
change: [+9.7946% +9.8948% +9.9914%] (p = 0.00 <
0.05)
Performance has regressed.
Found 5 outliers among 100 measurements (5.00%)
5 (5.00%) high mild
merge utf8 dictionary tuple
time: [7.6790 ms 7.6834 ms 7.6882 ms]
change: [+4.3158% +4.4152% +4.5234%] (p = 0.00 <
0.05)
Performance has regressed.
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high mild
merge mixed utf8 dictionary tuple
time: [13.357 ms 13.366 ms 13.376 ms]
change: [+1.9315% +2.1712% +2.4107%] (p = 0.00 <
0.05)
Performance has regressed.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild
merge mixed tuple time: [15.166 ms 15.226 ms 15.287 ms]
change: [+1.9570% +2.5373% +3.1653%] (p = 0.00 <
0.05)
Performance has regressed.
```
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
