alamb commented on code in PR #4530: URL: https://github.com/apache/arrow-datafusion/pull/4530#discussion_r1042123865
########## datafusion/core/tests/sqllogictests/test_files/ddl.slt: ########## @@ -0,0 +1,158 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at + +# http://www.apache.org/licenses/LICENSE-2.0 + +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +########## +## DDL Tests +########## + +statement ok +CREATE TABLE users AS VALUES(1,2),(2,3); + +query II rowsort +select * from users; +---- +1 2 +2 3 + +statement ok +insert into users values(2, 4); + +query II rowsort +select * from users; +---- +1 2 +2 3 +2 4 + +statement ok +insert into users values(1 + 10, 20); + +query II rowsort +select * from users; +---- +1 2 +2 3 +2 4 +11 20 + + +# Dropping table +statement ok +DROP TABLE users; + +# Table is gone +statement error +select * from users; + +# Can not drop it again +statement error +DROP TABLE user; + +# Can not insert into a undefined table +statement error +insert into user values(1, 20); + +########## +# Multipart identifier test (CREATE/DROP TABLE) +########## + +# Verify that creating tables with periods in their name works +# (note "foo.bar" is the table name, NOT table "bar" in schema "foo") Review Comment: > Without double quotes. foo foo will be treated as a schema? Yes > Is this "foo.bar.baz" a valid table name? can we add test for it? It is a valid name. Added tests in c03cf2b08 -- thank you for the suggestion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
