alamb commented on code in PR #4490:
URL: https://github.com/apache/arrow-datafusion/pull/4490#discussion_r1042191919
##########
datafusion/expr/src/expr.rs:
##########
@@ -244,6 +244,8 @@ pub enum Expr {
/// List of grouping set expressions. Only valid in the context of an
aggregate
/// GROUP BY expression list
GroupingSet(GroupingSet),
+ /// A place holder for parameters in a prepared statement.
+ Placeholder(String),
Review Comment:
@NGA-TRAN -- I was thinking about how to get the data type information from
the SQL planner to here
I was wondering what if you looked up the placeholder during planning and
then it would be available for the rest of the system
Something like
```suggestion
Placeholder {
/// The identifier
id: String,
/// The type the parameter will be filled in with
data_type: DataType,
},
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
