milesgranger commented on code in PR #14717:
URL: https://github.com/apache/arrow/pull/14717#discussion_r1042224484
##########
python/pyarrow/tests/parquet/test_parquet_file.py:
##########
@@ -329,3 +334,26 @@ def test_parquet_file_explicitly_closed(tempdir):
p.read()
assert not p.closed
assert p.closed # parquet file obj reports as closed
+
+
[email protected]
[email protected]("use_uri", (True, False))
+def test_parquet_file_with_filesystem(tempdir, s3_example_fs, use_uri):
+ s3_fs, s3_uri, s3_path = s3_example_fs
+
+ args = (s3_uri if use_uri else s3_path,)
+ kwargs = {} if use_uri else dict(filesystem=s3_fs)
+
+ table = pa.table({"a": range(10)})
+ pq.write_table(table, *args, **kwargs)
Review Comment:
Thanks! Would have used this suggestion directly, but it's `s3_path`, not
`path`.
https://github.com/apache/arrow/pull/14717/commits/4114478d79772f699ab5aa2109180f9064bace82
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
