viirya commented on code in PR #3288:
URL: https://github.com/apache/arrow-rs/pull/3288#discussion_r1042681824
##########
arrow-schema/src/field.rs:
##########
@@ -485,6 +485,20 @@ mod test {
use std::collections::hash_map::DefaultHasher;
use std::hash::{Hash, Hasher};
+ #[test]
+ fn test_new_with_string() {
+ // Fields should allow owned Strings to support reuse
+ let s = String::from("c1");
+ Field::new(s, DataType::Int64, false);
+ }
Review Comment:
Not sure if I understand the purpose clearly. Doesn't it work for now:
```
let s = String::from("c1");
Field::new(&s, DataType::Int64, false);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
