kou commented on code in PR #215:
URL: https://github.com/apache/arrow-adbc/pull/215#discussion_r1042700186
##########
dev/release/verify-release-candidate.sh:
##########
@@ -575,74 +606,54 @@ test_linux_wheels() {
show_header "Testing Python ${pyver} wheel for platform ${platform}"
CONDA_ENV=wheel-${pyver}-${platform} PYTHON_VERSION=${pyver}
maybe_setup_conda || exit 1
VENV_ENV=wheel-${pyver}-${platform} PYTHON_VERSION=${pyver}
maybe_setup_virtualenv || continue
- pip install
pyarrow-${TEST_PYARROW_VERSION:-${VERSION}}-cp${pyver/.}-cp${python/.}-${platform}.whl
- INSTALL_PYARROW=OFF ARROW_GCS=${check_gcs}
${ARROW_DIR}/ci/scripts/python_wheel_unix_test.sh ${ARROW_SOURCE_DIR}
+ pip install --force-reinstall
adbc_*-${TEST_PYARROW_VERSION:-${VERSION}}-cp${pyver/.}-cp${python/.}-${platform}.whl
+ pip install --force-reinstall
adbc_*-${TEST_PYARROW_VERSION:-${VERSION}}-py3-none-${platform}.whl
+ INSTALL_PYARROW=OFF ${ADBC_DIR}/ci/scripts/python_wheel_unix_test.sh
${ADBC_SOURCE_DIR}
done
done
}
test_macos_wheels() {
- local check_gcs=OFF
- local check_s3=ON
- local check_flight=ON
-
+ local python_versions="3.9 3.10 3.11"
# apple silicon processor
if [ "$(uname -m)" = "arm64" ]; then
- local python_versions="3.8 3.9 3.10 3.11"
- local platform_tags="macosx_11_0_arm64"
- local check_flight=OFF
+ local platform_tags="arm64"
else
- local python_versions="3.7m 3.8 3.9 3.10 3.11"
- local platform_tags="macosx_10_14_x86_64"
+ local platform_tags="x86_64"
fi
# verify arch-native wheels inside an arch-native conda environment
for python in ${python_versions}; do
local pyver=${python/m}
for platform in ${platform_tags}; do
show_header "Testing Python ${pyver} wheel for platform ${platform}"
- if [[ "$platform" == *"10_9"* ]]; then
- check_gcs=OFF
- check_s3=OFF
- fi
CONDA_ENV=wheel-${pyver}-${platform} PYTHON_VERSION=${pyver}
maybe_setup_conda || exit 1
VENV_ENV=wheel-${pyver}-${platform} PYTHON_VERSION=${pyver}
maybe_setup_virtualenv || continue
- pip install pyarrow-${VERSION}-cp${pyver/.}-cp${python/.}-${platform}.whl
- INSTALL_PYARROW=OFF ARROW_FLIGHT=${check_flight} ARROW_GCS=${check_gcs}
ARROW_S3=${check_s3} \
- ${ARROW_DIR}/ci/scripts/python_wheel_unix_test.sh ${ARROW_SOURCE_DIR}
+ pip install --force-reinstall
adbc_*-${TEST_PYARROW_VERSION:-${VERSION}}-cp${pyver/.}-cp${python/.}-macosx_*_${platform}.whl
+ pip install --force-reinstall
adbc_*-${TEST_PYARROW_VERSION:-${VERSION}}-py3-none-macosx_*_${platform}.whl
+ INSTALL_PYARROW=OFF ${ADBC_DIR}/ci/scripts/python_wheel_unix_test.sh
${ADBC_SOURCE_DIR}
done
done
}
test_wheels() {
- show_header "Downloading Python wheels"
+ show_header "Test Python wheels"
maybe_setup_conda python || exit 1
local wheels_dir=
if [ "${SOURCE_KIND}" = "local" ]; then
- wheels_dir="${ARROW_SOURCE_DIR}/python/repaired_wheels"
+ echo "Binary verification of local wheels is not currently implemented"
+ exit 1
else
- local download_dir=${ARROW_TMPDIR}/binaries
- mkdir -p ${download_dir}
-
if [ "$(uname)" == "Darwin" ]; then
local filter_regex=.*macosx.*
else
local filter_regex=.*manylinux.*
fi
Review Comment:
It seems that we can remove them too.
##########
.github/workflows/verify.yml:
##########
@@ -0,0 +1,101 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Verification
+
+on:
+ # schedule:
+ # - cron: "1 0 * * *"
+ workflow_dispatch:
+ inputs:
+ version:
+ description: "Version to verify"
+ required: false
+ type: string
+ default: ""
+ rc:
+ description: "RC to verify"
+ required: false
+ type: string
+ default: ""
+
+permissions:
+ contents: read
+
+jobs:
+ binary-unix:
+ name: "Verify Binaries/${{ matrix.os }}"
+ if: inputs.version != '' && inputs.rc != ''
+ runs-on: ${{ matrix.os }}
+ strategy:
+ matrix:
+ os: ["macos-latest", "ubuntu-latest"]
+ steps:
+ - uses: actions/checkout@v3
+ with:
+ fetch-depth: 0
+ persist-credentials: false
+ - name: Verify
+ shell: bash
+ env:
+ REPOSITORY: ${{ github.repository }}
+ TEST_DEFAULT: "0"
+ TEST_BINARIES: "1"
+ USE_CONDA: "1"
+ run: |
+ sudo -E ./dev/release/verify-release-candidate.sh ${{ inputs.version
}} ${{ inputs.rc }}
Review Comment:
Can we remove `sudo` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
