westonpace commented on code in PR #14663:
URL: https://github.com/apache/arrow/pull/14663#discussion_r1042806845
##########
cpp/src/arrow/compute/exec/expression.cc:
##########
@@ -1191,6 +1191,26 @@ Result<Expression> SimplifyWithGuarantee(Expression expr,
return expr;
}
+Result<Expression> RemoveNamedRefs(Expression src) {
+ if (!src.IsBound()) {
+ return Status::Invalid("RemoveNamedRefs called on unbound expression");
+ }
+ return ModifyExpression(
+ std::move(src),
+ [](Expression expr) {
+ const Expression::Parameter* param = expr.parameter();
+ if (param && !param->ref.IsFieldPath()) {
+ FieldPath ref_as_path(
+ std::vector<int>(param->indices.begin(), param->indices.end()));
+ return Expression(
+ Expression::Parameter{std::move(ref_as_path), param->type,
param->indices});
+ }
+
+ return expr;
+ },
+ [](Expression expr, ...) { return expr; });
Review Comment:
Fixed.
##########
cpp/src/arrow/compute/exec/expression.cc:
##########
@@ -1191,6 +1191,26 @@ Result<Expression> SimplifyWithGuarantee(Expression expr,
return expr;
}
+Result<Expression> RemoveNamedRefs(Expression src) {
+ if (!src.IsBound()) {
+ return Status::Invalid("RemoveNamedRefs called on unbound expression");
+ }
+ return ModifyExpression(
+ std::move(src),
+ [](Expression expr) {
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
