viirya commented on code in PR #3284:
URL: https://github.com/apache/arrow-rs/pull/3284#discussion_r1043079444
##########
parquet/src/arrow/arrow_writer/byte_array.rs:
##########
@@ -543,7 +549,7 @@ impl ColumnValueEncoder for ByteArrayEncoder {
fn encode<T>(values: T, indices: &[usize], encoder: &mut ByteArrayEncoder)
where
T: ArrayAccessor + Copy,
- T::Item: Copy + Ord + AsRef<[u8]>,
+ T::Item: Copy + Ord + AsRef<[u8]> + AsBytes,
Review Comment:
`.as_ref()` is okay, just requires one trait bound to `insert`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
