jorisvandenbossche commented on code in PR #14839:
URL: https://github.com/apache/arrow/pull/14839#discussion_r1043093152
##########
docs/source/_templates/layout.html:
##########
@@ -26,3 +26,9 @@
{# Silence the navbar #}
{% block docs_navbar %}
{% endblock %}
+
+{# Add version warnings #}
+{% block footer %}
+ {{ super() }}
+ <script type="text/javascript" src="/docs/versionwarning.js"></script>
Review Comment:
> How about referring `/docs/dev/_static/versionwarning.js` instead of
`/docs/_static/versionwarning.js`?
Ah, sorry, I just merged the PR on the site repo before checking the latest
comments here. Now, if we decide to go with /dev/, then it should be easy to
still update that in the arrow-site repo.
While doing it in /dev/ would avoid two PRs, in practice you can't test a
change in this repo though, and you always have to test it in arrow-site as
well to check the changes. So then actually doing a PR there as well isn't too
bad.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
