pitrou commented on code in PR #14877:
URL: https://github.com/apache/arrow/pull/14877#discussion_r1043513990
##########
go/arrow/cdata/cdata.go:
##########
@@ -583,7 +597,19 @@ func (imp *cimporter) importFixedSizePrimitive() error {
}
values = imp.importBitsBuffer(1)
}
- imp.data = array.NewData(imp.dt, int(imp.arr.length),
[]*memory.Buffer{nulls, values}, nil, int(imp.arr.null_count),
int(imp.arr.offset))
+
+ var dict *array.Data
+ if dt, ok := imp.dt.(*arrow.DictionaryType); ok {
Review Comment:
Sorry, I don't really read Go, but what happens if `ok` is false here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
