alamb commented on code in PR #4568:
URL: https://github.com/apache/arrow-datafusion/pull/4568#discussion_r1044560072
##########
datafusion/core/tests/sqllogictests/src/insert/mod.rs:
##########
@@ -40,9 +40,9 @@ pub async fn insert(ctx: &SessionContext, insert_stmt:
SQLStatement) -> Result<D
table_reference = object_name_to_table_reference(table_name)?;
// Todo: check columns match table schema
- match &*source.body {
+ match *source.body {
SetExpr::Values(values) => {
- insert_values = values.0.clone();
+ insert_values = values.rows;
Review Comment:
FYI @xudong963 I think I was able to avoid a clone in the sqllogictests
(not that it makes a huge difference)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
