zeroshade commented on issue #14883: URL: https://github.com/apache/arrow/issues/14883#issuecomment-1344561400
@lquerel Okay, two things: 1. I have a fix for the issue with encoding an empty map, I've opened the PR https://github.com/apache/arrow/pull/14904 to fix it. 2. You have an issue where you're doing extra releases on your builders in that branch. You create a record builder and then you grab the child builders and place them into various objects and then you call release which recursively calls release on your child objects which all release their builders. The issue is that calling release on the record builder will already call release on all of it's child builders and you never call retain on those child builders when you hand them off to your child objects. It's not a big problem, per se, but you can see it if you run your tests with `-tags assert` which turns on the debug asserts in the Arrow module and you'll find the "too many releases" errors. Just figured i'd point that out to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
