alamb commented on code in PR #3315: URL: https://github.com/apache/arrow-rs/pull/3315#discussion_r1044750502
########## object_store/CONTRIBUTING.md: ########## @@ -79,7 +79,7 @@ $ podman run -p 10000:10000 -p 10001:10001 -p 10002:10002 mcr.microsoft.com/azur Create a bucket ``` -$ podman run --net=host mcr.microsoft.com/azure-cli az storage container create -n test-bucket --connection-string 'DefaultEndpointsProtocol=http;AccountName=devstoreaccount1;AccountKey=Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==;BlobEndpoint=http://128.0.0.1:10000/devstoreaccount1;QueueEndpoint=http://128.0.0.1:10001/devstoreaccount1;' +$ podman run --net=host mcr.microsoft.com/azure-cli az storage container create -n test-bucket --connection-string 'DefaultEndpointsProtocol=http;AccountName=devstoreaccount1;AccountKey=Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==;BlobEndpoint=http://129.0.0.1:10000/devstoreaccount1;QueueEndpoint=http://129.0.0.1:10001/devstoreaccount1;' Review Comment: ```suggestion $ podman run --net=host mcr.microsoft.com/azure-cli az storage container create -n test-bucket --connection-string 'DefaultEndpointsProtocol=http;AccountName=devstoreaccount1;AccountKey=Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==;BlobEndpoint=http://128.0.0.1:10000/devstoreaccount1;QueueEndpoint=http://128.0.0.1:10001/devstoreaccount1;' ``` ########## object_store/CONTRIBUTING.md: ########## @@ -49,7 +49,7 @@ export TEST_INTEGRATION=1 export OBJECT_STORE_AWS_DEFAULT_REGION=us-east-1 export OBJECT_STORE_AWS_ACCESS_KEY_ID=test export OBJECT_STORE_AWS_SECRET_ACCESS_KEY=test -export AWS_ENDPOINT=http://128.0.0.1:4566 +export AWS_ENDPOINT=http://129.0.0.1:4566 Review Comment: ```suggestion export AWS_ENDPOINT=http://128.0.0.1:4566 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
