kou commented on code in PR #231:
URL: https://github.com/apache/arrow-adbc/pull/231#discussion_r1044809780
##########
c/driver/postgres/CMakeLists.txt:
##########
@@ -46,6 +46,10 @@ add_arrow_lib(adbc_driver_postgres
type.cc
OUTPUTS
ADBC_LIBRARIES
+ CMAKE_PACKAGE_NAME
+ AdbcDriverPostgres
Review Comment:
How about using "PostgreSQL" instead of "Postgres"?
"Postgres" is old name of "PostgreSQL" and the official site uses
"PostgreSQL" not "Postgres": https://www.postgresql.org/
##########
c/driver/sqlite/CMakeLists.txt:
##########
@@ -43,6 +43,10 @@ add_arrow_lib(adbc_driver_sqlite
utils.c
OUTPUTS
ADBC_LIBRARIES
+ CMAKE_PACKAGE_NAME
+ AdbcDriverSqlite
Review Comment:
How about using `AdbcDriverSQLite` because SQLite's CMake package name is
`SQLite3` not `Sqlite3`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
