tustvold commented on code in PR #3319:
URL: https://github.com/apache/arrow-rs/pull/3319#discussion_r1044847567
##########
parquet/src/bloom_filter/mod.rs:
##########
@@ -177,14 +177,17 @@ impl Sbbf {
}
/// Write the bloom filter data (header and then bitset) to the output
- pub(crate) fn write<W: Write>(&self, mut writer: W) -> Result<(),
ParquetError> {
+ pub(crate) fn write<W: Write>(&self, writer: W) -> Result<(),
ParquetError> {
+ // Use a BufWriter to avoid costs of writing individual blocks
Review Comment:
I wonder if we should be using `BufWriter` at a higher level :thinking: I
guess we mostly don't run into this issue as we write large page sized blobs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
