westonpace commented on code in PR #14186: URL: https://github.com/apache/arrow/pull/14186#discussion_r1045245905
########## cpp/src/arrow/engine/substrait/util_internal.h: ########## @@ -0,0 +1,32 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +// This API is EXPERIMENTAL. + +#pragma once + +#include "arrow/engine/substrait/visibility.h" +#include "substrait/algebra.pb.h" // IWYU pragma: export + +namespace arrow { +namespace engine { + +ARROW_ENGINE_EXPORT std::string EnumToString( + int value, const google::protobuf::EnumDescriptor* descriptor); Review Comment: Minor nit: Can you take in `const google::protobuf::EnumDescriptor&` (e.g. const reference instead of const pointer)? ########## cpp/src/arrow/engine/substrait/util_internal.h: ########## @@ -0,0 +1,32 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +// This API is EXPERIMENTAL. + Review Comment: ```suggestion ``` Internal headers probably don't need to be marked experimental ########## cpp/src/arrow/engine/substrait/util.h: ########## @@ -23,6 +23,7 @@ #include "arrow/compute/registry.h" #include "arrow/engine/substrait/api.h" #include "arrow/engine/substrait/options.h" +#include "arrow/engine/substrait/util_internal.h" Review Comment: You can't import `util_internal.h` from any public header file. Instead, import this directly from `relation_internal.cc`, `expression_internal.cc`, (any .cc file is ok, even if not marked internal), etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
