yaqi-zhao commented on code in PR #14585:
URL: https://github.com/apache/arrow/pull/14585#discussion_r1045376900
##########
cpp/src/arrow/util/bit_stream_utils.h:
##########
@@ -190,6 +195,14 @@ class BitReader {
/// Maximum byte length of a vlq encoded int64
static constexpr int kMaxVlqByteLengthForInt64 = 10;
+ const uint8_t* GetBuffer() { return buffer_ - 1; }
+
+ int GetBufferLen() { return max_bytes_ + 1; }
+
+ void updateValOffset(int batch_size) { val_offset_ += batch_size; }
+
+ int GetValOffset() { return val_offset_; }
Review Comment:
It makes sense. I have add GetBatchWithQpl in bit_stream_utils.h and not
expose the variables in BitReader. Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
