gf2121 commented on PR #14913: URL: https://github.com/apache/arrow/pull/14913#issuecomment-1347186468
Thanks @lidavidm for feedback! I think you are meaning to delegate methods on `Unsafe` in `MemoryUtil` (like what `PlatformDependent` do, just discard the params around netty). But i'm also seeing that `ArrowBuf` directly replaced `PlatformDependent.xxx` with `MemoryUtil.UNSAFE.xxx` in https://github.com/apache/arrow/pull/6131. So I wonder if the logic in `PlatformDependent`(like [this](https://github.com/netty/netty/blob/4.1/common/src/main/java/io/netty/util/internal/PlatformDependent0.java#L727)) is still wanted: * If yes, we can introduce delegating methods in this PR and replaces the direct operation on `MemoryUtil#UNSAFE` in a follow up. * If no, we can just operate on `MemoryUtil#UNSAFE` without introducing extra methods in `MemoryUtil`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
