kou commented on code in PR #237:
URL: https://github.com/apache/arrow-adbc/pull/237#discussion_r1046410643
##########
docs/source/cpp/driver/postgresql.rst:
##########
@@ -47,17 +54,17 @@ the :cpp:class:`AdbcDatabase`. This should be a
`connection URI
// Ignoring error handling
struct AdbcDatabase database;
AdbcDatabaseNew(&database, nullptr);
- AdbcDatabaseSetOption(&database, "uri",
"postgresql://localhost:5433", nullptr);
+ AdbcDatabaseSetOption(&database, "uri", "postgres://localhost:5433",
nullptr);
AdbcDatabaseInit(&database, nullptr);
.. tab-item:: Python
:sync: python
.. code-block:: python
- import adbc_driver_postgres.dbapi
+ import adbc_driver_postgresql.dbapi
- uri = "postgresql://localhost:5433"
- with adbc_driver_postgres.dbapi.connect(uri) as conn:
+ uri = "postgres://localhost:5433"
+ with adbc_driver_postgresql.dbapi.connect(uri) as conn:
Review Comment:
ditto.
##########
python/adbc_driver_postgresql/README.md:
##########
@@ -49,10 +49,10 @@ $ docker run -it --rm \
```
Then, to run the tests, set the environment variable specifying the
-Postgres URI before running tests:
+PostgreSQL URI before running tests:
```shell
-$ export
ADBC_POSTGRES_TEST_URI=postgres://localhost:5432/postgres?user=postgres&password=password
+$ export
ADBC_POSTGRESQL_TEST_URI=postgres://localhost:5432/postgres?user=postgres&password=password
Review Comment:
ditto.
##########
docs/source/cpp/driver/postgresql.rst:
##########
@@ -47,17 +54,17 @@ the :cpp:class:`AdbcDatabase`. This should be a
`connection URI
// Ignoring error handling
struct AdbcDatabase database;
AdbcDatabaseNew(&database, nullptr);
- AdbcDatabaseSetOption(&database, "uri",
"postgresql://localhost:5433", nullptr);
+ AdbcDatabaseSetOption(&database, "uri", "postgres://localhost:5433",
nullptr);
Review Comment:
We can use `postgresql://` or `postgres://` here but how about using
`postgresql://` here for consistency?
https://www.postgresql.org/docs/current/libpq-connect.html#id-1.7.3.8.3.6
> The URI scheme designator can be either postgresql:// or postgres://. Each
of the remaining URI parts is optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
