liukun4515 commented on PR #4562:
URL:
https://github.com/apache/arrow-datafusion/pull/4562#issuecomment-1347866893
> I wonder if it makes sense to also make use of `NestedLoopJoin` for cross
joins (with empty filter) and get rid of `CrossJoinExec`, as that should have
the same result while avoiding duplicate code. Does this make sense?
In the implementation of Join, this is join type in current codebase:
```
pub enum JoinType {
/// Inner Join
Inner,
/// Left Join
Left,
/// Right Join
Right,
/// Full Join
Full,
/// Left Semi Join
LeftSemi,
/// Right Semi Join
RightSemi,
/// Left Anti Join
LeftAnti,
/// Right Anti Join
RightAnti,
}
```
In the logical phase, we split the join to `cross join` with other join type.
I think we can fill a new issue to discuss it.
I prefer merge `cross join` to the join type.
cc @Dandandan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
