jorisvandenbossche commented on code in PR #14919: URL: https://github.com/apache/arrow/pull/14919#discussion_r1046859113
########## docs/source/developers/overview.rst: ########## @@ -97,9 +97,9 @@ Pull request and review When contributing a patch, use this list as a checklist of Apache Arrow workflow: * Submit the patch as a **GitHub pull request** against the **master branch**. -* So that your pull request syncs with the JIRA issue, **prefix your pull request - name with the JIRA issue id** (ex: - `ARROW-767: [C++] Filesystem abstraction <https://github.com/apache/arrow/pull/4225>`_). +* So that your pull request syncs with the GitHub issue, **prefix your pull request + title with the GitHub issue id** (ex: + `GH-14866: [C++] Remove internal GroupBy implementation <https://github.com/apache/arrow/pull/14867>`_). Review Comment: Should we keep both examples of prefixing with github issue id or JIRA number? Since until JIRAs are migrated, PRs will be opened targetting both github and jira issues ########## docs/source/developers/bug_reports.rst: ########## @@ -186,8 +173,8 @@ Arrow is an expansive project supporting many languages and organized into a number of components. Identifying the affected component(s) helps new issues get attention from appropriate contributors. -* Use the **Component** field to indicate the area of the project that your - issue pertains to (for example "Python" or "C++"). +* Use a **Component** label to indicate the area of the project that your + issue pertains to (for example "Component: Python" or "Component: C++"). Review Comment: It's certainly useful to document this (also for committers), but at the same time the wording above is not directly applicable in general for people opening issues, as they can't "use" (add) a label to issues themselves. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
