mapleFU commented on PR #14351: URL: https://github.com/apache/arrow/pull/14351#issuecomment-1348065307
> Would you be willing to submit a v2 PR later? It would be a pity if we supported v1 pages better than v2 pages. Sure, seems that v2 it's a bit more tricker, it should use accumulate crc: 1. `set crc = 0` 2. if rep-level exists, do `crc = checksum(rep-levels, 0)` 3. if def-level exists, do `crc = checksum(def-levels, crc)` 4. if compressed data exists, do `crc = checksum(data, crc)` It's really a bit more trickey here, so I think do it in same patch is complex. Let me finish it later @pitrou -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
