rtpsw commented on PR #14934: URL: https://github.com/apache/arrow/pull/14934#issuecomment-1349019853
cc @icexelloss @westonpace My challenge in is this PR was to add support for a negative tolerance without modifying the original code and algorithm beyond recognition. This is not so simple because a negative tolerance requires a future join, which requires per-key entry queues, and the original code was not designed with this in mind. Hopefully, the PR makes sense. The additional and well-covering test cases give me enough confidence in it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
