alamb commented on a change in pull request #8503:
URL: https://github.com/apache/arrow/pull/8503#discussion_r510216029
##########
File path: rust/datafusion/src/physical_plan/merge.rs
##########
@@ -103,37 +105,56 @@ impl ExecutionPlan for MergeExec {
self.input.execute(0).await
}
_ => {
- let tasks = (0..input_partitions).map(|part_i| {
+ let (sender, receiver) =
mpsc::unbounded::<ArrowResult<RecordBatch>>();
Review comment:
Now that I think about it, I don't think calling `join_all` before
returning `MergeStream` is needed here (as that requires all tasks to complete
executing before anything can consume the output of this operator).
If we want to pass errors back up stream (aka call join_all eventually) I
wonder if we can put `handles` into `MergeStream` and call `join_all` after
`input` is done.
I am thinking all of this theoretically -- not having actually ever
expressed such a thing in Rust / futures, BTW. So thanks for bearing with me!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
