thisisnic commented on code in PR #14930:
URL: https://github.com/apache/arrow/pull/14930#discussion_r1047654166
##########
r/tests/testthat/test-filesystem.R:
##########
@@ -130,6 +129,21 @@ test_that("LocalFileSystem + Selector", {
expect_equal(sum(types == FileType$Directory), 1L)
})
+test_that("clean_path_abs() marks its output as utf-8", {
+ f <- tempfile(fileext = "Público")
+ on.exit(unlink(f))
+
+ file.create(f)
+ f_utf8 <- enc2utf8(normalizePath(f, winslash = "/"))
+ f_latin1 <- iconv(f_utf8, "utf-8", "latin1")
+
+ expect_identical(clean_path_abs(f_utf8), f_utf8)
Review Comment:
Nah, the second ones in those groups fail for me too on Ubuntu, it was just
that particular expectation I was asking about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
