alamb commented on code in PR #4599:
URL: https://github.com/apache/arrow-datafusion/pull/4599#discussion_r1047684101
##########
datafusion/optimizer/src/eliminate_limit.rs:
##########
@@ -40,27 +40,45 @@ impl OptimizerRule for EliminateLimit {
fn optimize(
&self,
plan: &LogicalPlan,
- optimizer_config: &mut OptimizerConfig,
+ _optimizer_config: &mut OptimizerConfig,
Review Comment:
I find it strange to use a variable named `_something` -- I thought the Rust
convention was to name variables starting with `_` when they were *not* used 🤔
##########
datafusion/optimizer/src/decorrelate_where_exists.rs:
##########
@@ -107,7 +111,7 @@ impl OptimizerRule for DecorrelateWhereExists {
}
// iterate through all exists clauses in predicate, turning
each into a join
- let mut cur_input = (**filter_input).clone();
+ let mut cur_input = filter_input.clone();
Review Comment:
❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
