kou commented on PR #14235: URL: https://github.com/apache/arrow/pull/14235#issuecomment-1350558076
> (how many people are building aws-sdk-cpp separately from source--it's not available in package managers so that's what this entails, right?--and then trying to install the R package?) Right. aws-sdk-cpp is available only on some package managers such as Homebrew, MSYS2 and vcpkg. > My other concern is that it now looks like we have all of these other system dependencies, and that we're no longer testing more stripped down environments that don't have all of these libraries installed. Do I read that correctly? Correct. It's out of scope of this pull request but the following approach may be better: * We use shared libraries by default. (Users who use source build don't need to use static linking, right?) * We use static libraries only for building pre-built binaries. If we use shared libraries, we only need `libcurl-dev`. We don't need to install additional packages such as `libssh-dev` because `libcurl-dev` depends on needed packages for shared linking. > That said, I trust Kou's judgment, so I won't get in the way of merging. Thanks! I'll rebase this branch, confirm Crossbow results and merge this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
