kou commented on code in PR #14585:
URL: https://github.com/apache/arrow/pull/14585#discussion_r1048123988
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -2203,6 +2214,51 @@ if(ARROW_WITH_RAPIDJSON)
endif()
endif()
+macro(build_qpl)
+ message(STATUS "Building QPL from source")
+ set(QPL_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/qpl_ep/src/qpl_ep-install")
+ set(QPL_STATIC_LIB_NAME
${CMAKE_STATIC_LIBRARY_PREFIX}qpl${CMAKE_STATIC_LIBRARY_SUFFIX})
+ set(QPL_STATIC_LIB "${QPL_PREFIX}/lib/${QPL_STATIC_LIB_NAME}")
+ set(QPL_CMAKE_ARGS ${EP_COMMON_CMAKE_ARGS} -DCMAKE_INSTALL_LIBDIR=lib
+ "-DCMAKE_INSTALL_PREFIX=${QPL_PREFIX}")
+ set(QPL_PATCH_COMMAND)
+ find_package(Patch)
+ if(Patch_FOUND)
+ # This patch is for Qpl <= v0.2.0
Review Comment:
We can use a patch that is not yet merged but we don't want to maintain
patches to reduce maintenance cost.
So we must upstream our patches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
