westonpace commented on code in PR #14682:
URL: https://github.com/apache/arrow/pull/14682#discussion_r1048127924
##########
python/pyarrow/src/arrow/python/udf.cc:
##########
@@ -83,16 +135,17 @@ struct PythonUdf : public compute::KernelState {
}
};
-Status PythonUdfExec(compute::KernelContext* ctx, const ExecSpan& batch,
- ExecResult* out) {
+Status PythonUdfExec(compute::KernelContext* ctx, const compute::ExecSpan&
batch,
+ compute::ExecResult* out) {
auto udf = static_cast<PythonUdf*>(ctx->kernel()->data.get());
return SafeCallIntoPython([&]() -> Status { return udf->Exec(ctx, batch,
out); });
}
-} // namespace
-
-Status RegisterScalarFunction(PyObject* user_function,
ScalarUdfWrapperCallback wrapper,
- const ScalarUdfOptions& options) {
+Status RegisterScalarLikeFunction(PyObject* user_function,
Review Comment:
That sounds good to me. We can worry about distinguishing when we have a
case that doesn't fit the pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
