pitrou commented on PR #14585: URL: https://github.com/apache/arrow/pull/14585#issuecomment-1351079637
I haven't looked at this in detail but my general sentiment is negative. This PR does seem to provide very significant speedups. However, it comes with several downsides: * the accelerator is Intel-specific * it will only be provided on high-end CPUs (Xeon Scalable), and maybe even only some of them due to market segmentation * it requires a dedicated third-party library for which we have to maintain vendoring support Generally, our Arrow and Parquet C++ maintenance bandwidth is very limited, with few active maintainers. This PR adds maintenance overhead for no value to most users. If Intel were a significant contributor to Arrow and Parquet maintenance, I would view this PR (and other similar one-shot PRs that add accelerations to select parts of the codebase) more favorably. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
