pitrou commented on PR #14753: URL: https://github.com/apache/arrow/pull/14753#issuecomment-1351365114
> Not quite sure if you think exposing the one common `ResolvedSortKey` in the header would be worthwhile - since I basically just copied it into select-k's `RecordBatchSelector`. In practice, there are 3 unique `ResolvedSortKey` definitions across 4 classes. Basically there should be two possible `ResolvedSortKey` implementations: one for record batch (contiguous) input, the other for table (chunked) input. So, yes, I think those two implementations should be put in the header. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
