bkietz commented on a change in pull request #7901:
URL: https://github.com/apache/arrow/pull/7901#discussion_r510399380
##########
File path: cpp/src/arrow/json/converter.cc
##########
@@ -123,13 +123,11 @@ class NumericConverter : public PrimitiveConverter {
RETURN_NOT_OK(builder.Resize(dict_array.indices()->length()));
auto visit_valid = [&](string_view repr) {
- value_type value;
- if (!internal::ParseValue(numeric_type_, repr.data(), repr.size(),
&value)) {
- return GenericConversionError(*out_type_, ", couldn't parse:", repr);
+ if (auto value = internal::ParseValue(numeric_type_, repr)) {
Review comment:
I think these can be fixed, but I'd like to wait for a follow up so we
don't conflate any perf impact of this PR with unrelated changes inside CSV
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
