kou commented on code in PR #14082:
URL: https://github.com/apache/arrow/pull/14082#discussion_r1049230319
##########
cpp/src/arrow/flight/sql/CMakeLists.txt:
##########
@@ -117,18 +119,39 @@ if(ARROW_BUILD_TESTS OR ARROW_BUILD_EXAMPLES)
endif()
endif()
+ # Fetch ADBC test suite
+ cmake_minimum_required(VERSION 3.11)
+ include(FetchContent)
+ fetchcontent_declare(adbc
+ GIT_REPOSITORY https://github.com/apache/arrow-adbc.git
+ GIT_TAG ddd715a443cf2e5edd15c639af3845afe81af4ee)
+ fetchcontent_makeavailable(adbc)
Review Comment:
Hmm, no. I meant the following:
1. Create `CMakeLists.txt` in
https://github.com/apache/arrow-adbc/tree/main/c/validation like
https://github.com/apache/arrow-adbc/blob/main/c/driver_manager/CMakeLists.txt
2. Apache Arrow C++ Flight SQL developers install
https://github.com/apache/arrow-adbc/tree/main/c/validation by 1.
3. Apache Arrow C++ uses 2.
We may also implement 2. in `cpp/cmake_modules/ThirdpartyToolchain.cmake`
like other dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
