tustvold commented on code in PR #3345:
URL: https://github.com/apache/arrow-rs/pull/3345#discussion_r1049493136
##########
arrow/src/compute/kernels/arity.rs:
##########
@@ -135,14 +138,15 @@ where
downcast_dictionary_array! {
array => unary_dict::<_, F, T>(array, op),
t => {
- if t == &T::DATA_TYPE {
+ if t == &T::DATA_TYPE || (t.is_decimal() &&
T::DATA_TYPE.is_decimal()) {
Review Comment:
Could we use discriminant instead - in the same way that we do
`PrimitiveArray::from(ArrayData)`?
Edit: In fact I'm not sure of the purpose of this check at all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
