jorisvandenbossche commented on issue #14946: URL: https://github.com/apache/arrow/issues/14946#issuecomment-1352935344
I don't think we actually use the specific `Get*` methods on `FieldRef`/`FieldPath` anywhere _with array input_, not even in the compute module (whether we use FieldRef/FieldPath in general outside of compute, not directly an idea). I have been looking through the places where we call `FieldRef/FieldPath::Get*` internally, and I only see places where we call this with a type or schema (which doesn't have this nuance of raw child vs flattened). The only place I found (based on a quick look, outside `type.cc`/`type_test.cc`) is in the tests in scanner_test.cc: https://github.com/apache/arrow/blob/5c1044fce55ed0e373a622cb8ee3b97a1a34799a/cpp/src/arrow/dataset/scanner_test.cc#L672-L675 and I would say this is only "correct" because the test batch doesn't have missing values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
