mingmwang commented on PR #4618: URL: https://github.com/apache/arrow-datafusion/pull/4618#issuecomment-1352950506
@jackwener I think you can leverage the `TreeNodeRewritable` trait to unify the code. And there are two downsides of the approach: 1) There will be additional `clone()` call to the plan structs. 2) When implement rules, if we want to implement the rule as a top down process, need to be very careful with transform_down() closures, it might cause stack over flow(because of no duplication invocation check). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
