mapleFU commented on code in PR #14959:
URL: https://github.com/apache/arrow/pull/14959#discussion_r1049847663
##########
cpp/src/parquet/encoding.cc:
##########
@@ -2138,8 +2138,6 @@ class DeltaBitPackEncoder : public EncoderImpl, virtual
public TypedEncoder<DTyp
"but it's " +
std::to_string(values_per_block % mini_blocks_per_block));
}
- // Reserve enough space at the beginning of the buffer for largest
possible header.
- PARQUET_THROW_NOT_OK(sink_.Advance(kMaxPageHeaderWriterSize));
Review Comment:
> I was concerned that there is no sufficient space reserved for the header
if the block contains empty values. :)
The code is copied from the original constructor implementions. It will:
* reserve space for maximum header size
* append values
* modify header, and return slice buffer
Seems that there should be space here, if original implemention works well...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
