drin commented on PR #13487: URL: https://github.com/apache/arrow/pull/13487#issuecomment-1353825428
rebased. I think this should be good, unless someone wants me to change the test data in the `Hash64IntMap` case ([scalar_hash_test.cc#L104](https://github.com/drin/arrow/blob/ARROW-8991-newfn-scalar-hash/cpp/src/arrow/compute/kernels/scalar_hash_test.cc#L104)): ```cpp // test data we directly hash to compare to the output of the scalar hash function std::vector<uint16_t> test_vals_first{7, 67, 3, 31, 17, 29}; std::vector<int16_t> test_vals_second{67, 7, 31, 3, 29, 17}; // input for the scalar hash function auto test_map = ArrayFromJSON(map(uint16(), int16()), R"([[[ 7, 67]], [[67, 7]], [[ 3, 31]], [[31, 3]], [[17, 29]], [[29, 17]]])"); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
