liukun4515 commented on code in PR #4648:
URL: https://github.com/apache/arrow-datafusion/pull/4648#discussion_r1050356483
##########
datafusion/physical-expr/src/expressions/binary/kernels_arrow.rs:
##########
@@ -503,9 +444,6 @@ mod tests {
let left_decimal_array = create_decimal_array(&[Some(101)], 10, 1);
let right_decimal_array = create_decimal_array(&[Some(0)], 1, 1);
- let err =
Review Comment:
No,
The behavior of divide for decimal array with decimal array was changed.
In the previous implementation, we will check the 0 for dividend, but in the
kernel `divide_opt` of arrow-rs, the result will be None if the right is zero
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
