kou commented on code in PR #14839:
URL: https://github.com/apache/arrow/pull/14839#discussion_r1050436231
##########
docs/source/_templates/layout.html:
##########
@@ -26,3 +26,9 @@
{# Silence the navbar #}
{% block docs_navbar %}
{% endblock %}
+
+{# Add version warnings #}
+{% block footer %}
+ {{ super() }}
+ <script type="text/javascript" src="/docs/versionwarning.js"></script>
Review Comment:
Yes. I wanted to solve "in practice you can't test a change in this repo
though, and you always have to test it in arrow-site as well to check the
changes".
I thought that we can test almost features (I understand that we can't test
all features) with this approach. We don't need to change
`src=.../versionwaning.js` in all `.html` manually to test locally with this
approach.
If this approach doesn't help `versionwarning.js` developers/maintainers,
I'm OK without this approach. (I'm OK that they always need apache/arrow-site.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
