jorgecarleitao opened a new pull request #8517:
URL: https://github.com/apache/arrow/pull/8517


   Currently, the code on `array/ord.rs` is centered around intra-array 
comparison. However, this does not allow to compare values from two different 
arrays, which is required on e.g. merge-sort operations.
   
   This PR:
   * simplifies the code around `sort` by splitting it in smaller functions for 
ease of understanding (first 2 commits)
   * adds a benchmark to the `sort` kernel which I used to verify that there 
was no performance regression  (3rd commit)
   * simplifies and generalizes the code around `ord` to support comparisons 
between two arrays (that may be the same), 4th commit
   * adds some more tests to edge cases around float comparison (nan and zeros)
   
   There was no performance change on my computer.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to