alamb commented on code in PR #14179:
URL: https://github.com/apache/arrow/pull/14179#discussion_r1051182592


##########
cpp/src/arrow/array.h:
##########
@@ -34,10 +34,15 @@
 /// @{
 /// @}
 
+/// \defgroup encoded-arrays Concrete classes for encoded arrays
+/// @{
+/// @}
+
 #include "arrow/array/array_base.h"       // IWYU pragma: keep
 #include "arrow/array/array_binary.h"     // IWYU pragma: keep
 #include "arrow/array/array_decimal.h"    // IWYU pragma: keep
 #include "arrow/array/array_dict.h"       // IWYU pragma: keep
+#include "arrow/array/array_encoded.h"    // IWYU pragma: keep

Review Comment:
   Maybe `array_rle` or `array_ree` would be a better name for RunEndEncoded 
arrays
   
   DictionaryArrays are also a form of encoding so calling this `array_encoded` 
seems a bit vague



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to