kou commented on code in PR #14925:
URL: https://github.com/apache/arrow/pull/14925#discussion_r1051210607
##########
python/CMakeLists.txt:
##########
@@ -433,63 +575,46 @@ if(PYARROW_BUILD_CUDA)
find_package(ArrowCUDA REQUIRED)
if(PYARROW_BUNDLE_ARROW_CPP)
- bundle_arrow_lib(ARROW_CUDA_SHARED_LIB SO_VERSION ${ARROW_SO_VERSION})
+ bundle_arrow_lib(${ARROW_CUDA_SHARED_LIB} SO_VERSION ${ARROW_SO_VERSION})
if(MSVC)
- bundle_arrow_import_lib(ARROW_CUDA_IMPORT_LIB)
+ bundle_arrow_import_lib(${ARROW_CUDA_IMPORT_LIB})
endif()
endif()
set(CUDA_LINK_LIBS ArrowCUDA::arrow_cuda_shared)
set(CYTHON_EXTENSIONS ${CYTHON_EXTENSIONS} _cuda)
+ set_source_files_properties(pyarrow/_cuda.pyx PROPERTIES CYTHON_API TRUE)
endif()
# Dataset
if(PYARROW_BUILD_DATASET)
- # Arrow Dataset
- find_package(ArrowDataset REQUIRED)
-
if(PYARROW_BUNDLE_ARROW_CPP)
- bundle_arrow_lib(ARROW_DATASET_SHARED_LIB SO_VERSION ${ARROW_SO_VERSION})
+ bundle_arrow_lib(${ARROW_DATASET_SHARED_LIB} SO_VERSION
${ARROW_SO_VERSION})
if(MSVC)
- bundle_arrow_import_lib(ARROW_DATASET_IMPORT_LIB)
+ bundle_arrow_import_lib(${ARROW_DATASET_IMPORT_LIB})
endif()
endif()
set(DATASET_LINK_LIBS ArrowDataset::arrow_dataset_shared)
set(CYTHON_EXTENSIONS ${CYTHON_EXTENSIONS} _dataset)
endif()
+# Parquet
if(PYARROW_BUILD_PARQUET)
- # Parquet
- find_package(Parquet REQUIRED)
Review Comment:
Good catch! `Parquet` is found by `find_package(ArrowDataset REQUIRED)`
implicitly but we should call `find_package(Parquet REQUIRED)` explicitly. I'll
fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
