alamb opened a new pull request, #4665: URL: https://github.com/apache/arrow-datafusion/pull/4665
# Which issue does this PR close? Closes https://github.com/apache/arrow-datafusion/issues/4570 re https://github.com/apache/arrow-datafusion/issues/4460 # Rationale for this change TLDR I want to be able to write a script and capture expected output easily See https://github.com/apache/arrow-datafusion/issues/4570 # What changes are included in this PR? 1. Update sqllogictest = "0.10.0" 1. add a `--complete` command line flag to sqllogictest 2. add documentation on how to update the files # Are these changes tested? not directly -- they are a tool for testing As an example: As an example, I ported two tests from aggregates.rs to aggregate.slt like: ``` # array_agg_zero query U SELECT ARRAY_AGG([]); # array_agg_one query U SELECT ARRAY_AGG([1]); ``` Note I didn't put in the expected results Then I ran in complete mode: ```shell cargo test --test sqllogictests -- aggregate --complete ``` ``` # array_agg_zero query U SELECT ARRAY_AGG([]); ---- [] # array_agg_one query U SELECT ARRAY_AGG([1]); ---- [[1]] ``` 🎉 # Are there any user-facing changes? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
