lidavidm commented on code in PR #248: URL: https://github.com/apache/arrow-adbc/pull/248#discussion_r1051659619
########## c/validation/CMakeLists.txt: ########## @@ -0,0 +1,58 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +cmake_minimum_required(VERSION 3.18) +include(CMakePackageConfigHelpers) +project(adbc_validation LANGUAGES CXX) + +find_package(GTest REQUIRED) +get_filename_component(REPOSITORY_ROOT "../../" ABSOLUTE) + +add_library(adbc_validation STATIC adbc_validation.cc adbc_validation_util.cc) +target_compile_features(adbc_validation PRIVATE cxx_std_17) +target_include_directories(adbc_validation SYSTEM PRIVATE "${REPOSITORY_ROOT}" + "${REPOSITORY_ROOT}/c/vendor/") +target_link_libraries(adbc_validation PUBLIC nanoarrow GTest::gtest GTest::gmock) + +set_target_properties(adbc_validation + PROPERTIES PUBLIC_HEADER "adbc_validation.h;adbc_validation_util.h") + +install(TARGETS adbc_validation + EXPORT AdbcValidationTargets + LIBRARY DESTINATION lib + PUBLIC_HEADER DESTINATION include/adbc_validation/) + +write_basic_package_version_file( + "${CMAKE_CURRENT_BINARY_DIR}/AdbcValidation/AdbcValidationConfigVersion.cmake" + VERSION main Review Comment: Updated here to use GNUInstallDirs. I split the version define into a new file containing only the version; I'll update the other PR once this lands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
