kou commented on issue #15017:
URL: https://github.com/apache/arrow/issues/15017#issuecomment-1356876550
I think that we should improve our test for `-DARROW_USE_GLOG=ON` build:
```diff
diff --git a/python/pyarrow/tests/test_memory.py
b/python/pyarrow/tests/test_memory.py
index 092c50de33..77057bef59 100644
--- a/python/pyarrow/tests/test_memory.py
+++ b/python/pyarrow/tests/test_memory.py
@@ -134,8 +134,14 @@ def check_env_var(name, expected, *,
expect_warning=False):
res.check_returncode() # fail
errlines = res.stderr.splitlines()
if expect_warning:
- assert len(errlines) == 1
- assert f"Unsupported backend '{name}'" in errlines[0]
+ assert len(errlines) == 1 or len(errlines) == 2
+ if len(errlines) == 1:
+ # ARROW_USE_GLOG=OFF
+ assert f"Unsupported backend '{name}'" in errlines[0]
+ else
+ # ARROW_USE_GLOG=ON
+ assert f"InitGoogleLoggingd()" in errlines[0]
+ assert f"Unsupported backend '{name}'" in errlines[1]
else:
assert len(errlines) == 0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
