cyb70289 commented on code in PR #14353:
URL: https://github.com/apache/arrow/pull/14353#discussion_r1051815984
##########
cpp/src/parquet/column_reader.cc:
##########
@@ -850,12 +850,23 @@ class ColumnReaderImplBase {
current_encoding_ = encoding;
current_decoder_->SetData(static_cast<int>(num_buffered_values_), buffer,
static_cast<int>(data_size));
+ if (!hasSet_uses_opt_) {
+ if (current_encoding_ == Encoding::PLAIN_DICTIONARY ||
+ current_encoding_ == Encoding::PLAIN ||
+ current_encoding_ == Encoding::RLE_DICTIONARY) {
+ uses_opt_ = true;
+ }
+ hasSet_uses_opt_ = true;
+ }
}
int64_t available_values_current_page() const {
return num_buffered_values_ - num_decoded_values_;
}
+ bool hasSet_uses_opt_ = false;
+ bool uses_opt_ = false;
Review Comment:
Try to make it simple. I don't think there's any performance consideration
here.
E.g., define a helper function
`bool UsesOpt() const { return (current_encoding == xxx || ....; }`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
