xhochy commented on code in PR #15014:
URL: https://github.com/apache/arrow/pull/15014#discussion_r1052032848
##########
dev/tasks/conda-recipes/r-arrow/build.sh:
##########
@@ -5,13 +5,14 @@ export DISABLE_AUTOBREW=1
# arrow uses C++17
export ARROW_R_CXXFLAGS="${ARROW_R_CXXFLAGS} -std=c++17"
+export LIBARROW_BUILD=false
if [[ "${target_platform}" == osx-* ]]; then
# See
https://conda-forge.org/docs/maintainer/knowledge_base.html#newer-c-features-with-old-sdk
export ARROW_R_CXXFLAGS="${ARROW_R_CXXFLAGS}
-D_LIBCPP_DISABLE_AVAILABILITY"
fi
-export
PKG_CONFIG_PATH="${PREFIX}/lib/pkgconfig${PKG_CONFIG_PATH:+:${PKG_CONFIG_PATH}}"
+export
PKG_CONFIG_PATH="${BUILD_PREFIX}/lib/pkgconfig${PKG_CONFIG_PATH:+:${PKG_CONFIG_PATH}}"
Review Comment:
This doesn't look right. `BUILD_PREFIX` is the build system, not host. It
has been failing in the cross-compiling case and this change makes me
suspicious whether we then link to the wrong libraries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
